1. Pull request workflow
2. Creating the pull request
- Don't do it in the description, do it in the code itself as comments.
- Consider refactoring and changing variable/function/method names to make it clearer.
PR Self Review:
Look for the following problems:
- PS: Fowler said "Yagni only applies to capabilities built into the software to support a presumptive feature, it does not apply to effort to make the software easier to modify".
Responding to feedback
- Be grateful for the reviewer's suggestions. ("Good call. I'll make that change.").
- Don't take it personally. The review is of the code, not yourself.
- Try to understand the reviewer's perspective.